Skip to content

Replace flaky GIL/performance test with a deterministic heartbeat-based GIL probe#35

Merged
RmSchaffert merged 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/fix_gil_release_test
Jun 12, 2026
Merged

Replace flaky GIL/performance test with a deterministic heartbeat-based GIL probe#35
RmSchaffert merged 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/fix_gil_release_test

Conversation

@xupinjie

Copy link
Copy Markdown
Collaborator

Description

Replace flaky GIL/performance test with a deterministic heartbeat-based GIL probe

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

@xupinjie xupinjie requested a review from RmSchaffert June 12, 2026 08:13
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

RmSchaffert
RmSchaffert previously approved these changes Jun 12, 2026

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a sign-off for the commit.

@RmSchaffert RmSchaffert self-requested a review June 12, 2026 09:19
@RmSchaffert RmSchaffert dismissed their stale review June 12, 2026 09:20

Sing-off needed for the commit

…ed GIL probe

Signed-off-by: pinjie <pinjiex@nvidia.com>
@xupinjie xupinjie force-pushed the pinjie/fix_gil_release_test branch from 37c32c6 to 22cde06 Compare June 12, 2026 09:44

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RmSchaffert RmSchaffert merged commit 7038093 into NVIDIA:main Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants